[1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

Ulrik Dickow udickow at gmail.com
Wed Jun 13 09:42:49 CDT 2012

Here's a new version of the patch that follows all of your 3 requests:

Den 12-06-2012 13:11, Nikolay Sivov skrev:
> [...]
> Please use something like CLSID array with every available Document
> CLSID, instead of only testing 2 of them. There's a lot of examples for
> that in saxreader.c.
> [...]
> It's better to avoid nested test calls like that imho, you could just
> add another call in main test list.
> [...]
> When this is running on all CLSIDs please add free_bstrs() here.

Is it ok now?

Since it contains new functionality, namely test of more document
versions (CLSIDs) than before, it was necessary to change the Subject of
the patch.  How do I make sure that the old patch changes status to
Superseded on http://source.winehq.org/patches/ ?  E.g. use the old
subject with "(try 2)" added in the E-mail header, but the new Subject
inside the attachment?

Regards, Ulrik Dickow
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msxml3-tests-Test-namespace-change-for-all-document-.patch
Type: text/x-patch
Size: 6061 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20120613/fcf4f0ef/attachment.bin>

More information about the wine-devel mailing list