[05/11] windowscodecs: Add support for more types of IFD fields. Resend.

Dmitry Timoshkov dmitry at baikal.ru
Thu Jun 14 20:35:32 CDT 2012


Alexandre Julliard <julliard at winehq.org> wrote:

> > +     case IFD_BYTE:
> > +     case IFD_SBYTE:
> > +        if (count == 1)
> > +        {
> > +            item->value.u.bVal = *(BYTE *)&value;
> > +            break;
> > +        }
> > +        FIXME("loading multiple byte fields is not implemented\n");
> > +        break;
> 
> This seems to contradict the endianness support. Are you really supposed
> to byte-swap arrays of bytes?

It doesn't matter at this point. I'm planning to add a test for endianness
handling in IFD reader, if this is proved to be wrong the fix will be trivial.
Please consider accepting the patch as is.

-- 
Dmitry.



More information about the wine-devel mailing list