[PATCH] winepulse.drv: Add PulseAudio driver
m.b.lankhorst at gmail.com
Sat Jun 16 11:05:08 CDT 2012
What happened to the stamped capture buffers? Why is held_frames added?
This doesn't look like an attempt to get my driver in, it looks like a rewrite
by someone who doesn't understand why I made the design decisions I made for
If you don't paste all the mmdevapi tests with the fix in my git tree, it's a
regression. I don't want to see held_Frames because it's a shadow buffer.
If winmm and dsound don't work without it, they're wrong, fix those.
The logic I kept for timestamping audio buffers was removed which just
makes timestamping less accurate on capture buffers. Was this driver
even tested on low latency? There was a reason I kept track of all
packets in a linked list, no need to do held_frames logic.
I genuinely do want a good driver to go in, but this just isn't it.
There is also no reason to have an INCREASED period size for exclusive
compared to shared. I'm currently not handling exclusive because there
are no good tests for it.
and "hooray_cb" ?
If this is going to be accepted (likely, sadly) I want to have this added to the
Rejected-by: Maarten Lankhorst <m.b.lankhorst at gmail.com>
PS: Still sad that you chose to reject my original driver not based on any merits.
More information about the wine-devel