[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

GOUJON Alexandre ale.goujon at gmail.com
Sun Jun 17 05:39:50 CDT 2012

On 06/17/2012 01:19 PM, Nikolay Sivov wrote:
> On 6/17/2012 13:11, Alexandre Goujon wrote:
>>             case DvdManufacturerDescriptor:
>> +            nt_desc.manf->Header.Length = 0x0802;
>> +            nt_desc.manf->Header.Reserved[0] = 0;
>> +            nt_desc.manf->Header.Reserved[1] = 0;
> Does this length mean something? Looks a bit dirty to leave hardcoded 
> things like that, but maybe I don't know details.
This was hard-coded for the physical descriptor.
I tested it with the (few) DVD's I have at home.
But that's what tests are for : let (more) people check the behaviour 
with more hardware/software/CDs/DVDs (than the developer has)

Anyway, thanks for the review (especially a Sunday)

More information about the wine-devel mailing list