[1/5] windowscodecs: Implement IWICBitmapScaler::GetSize.

Dmitry Timoshkov dmitry at baikal.ru
Wed Jun 27 11:25:57 CDT 2012


Vincent Povirk <madewokherd at gmail.com> wrote:

>  static HRESULT WINAPI BitmapScaler_GetSize(IWICBitmapScaler *iface,
>      UINT *puiWidth, UINT *puiHeight)
>  {
> -    FIXME("(%p,%p,%p): stub\n", iface, puiWidth, puiHeight);
> +    BitmapScaler *This = impl_from_IWICBitmapScaler(iface);
> +    TRACE("(%p,%p,%p)\n", iface, puiWidth, puiHeight);
>  
> -    return E_NOTIMPL;
> +    if (!This->source)
> +        return WINCODEC_ERR_WRONGSTATE;
> +
> +    *puiWidth = This->width;
> +    *puiHeight = This->height;
> +
> +    return S_OK;

This patch and remaning patches in the sequence completely miss any
parameter checking.

-- 
Dmitry.



More information about the wine-devel mailing list