Unused msvcp60 functions

Francois Gouget fgouget at free.fr
Thu Jun 28 09:33:42 CDT 2012


On Thu, 28 Jun 2012, Piotr Caban wrote:
[...]
> The function were not removed to make msvcp60 and msvcp90 more similar 
> (and probably because I didn't use -Wunused-function option). Thanks to 
> it one can copy misc.c file between the dlls when it's modified.

Actually there are some implementation differences between msvcp60's and 
msvcp90's misc.c code. In particular for the init_lockit(), 
free_lockit() and various _Lockit_ctor_*() functions. Are the two 
implementations supposed to be identical? There's no indication that the 
two misc.c files are supposed to remain synchronized but if that's the 
goal, one option would be to move the msvcp90-specific functions to 
another file so that it remains easy to copy and/or diff these two 
misc.c files.

Also a lot of functions actually rely on forwarding to msvcp90. Should 
this be used for the misc.c functions too?

-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
                 There are 10 types of people in the world...
               those who understand binary and those who don't.



More information about the wine-devel mailing list