[PATCH 2/8] d3drm: Specify when a method is forwarded to another interface. (resend)
titan.costa at gmail.com
Wed Mar 14 14:44:49 CDT 2012
Le 14/03/2012 19:23, Alexandre Julliard a écrit :
> Christian Costa<titan.costa at gmail.com> writes:
>> We forward the method to it's implementation in another interface which is
>> a "partial stub" (in reality it is more a "partial implementation" as you
>> will see in next patches).
>> From the log we can see a method redirected from interface 2 to interface 3
>> and then that the method is implemented as "partial stub".
>> Without the patches I see in the log a partial stub from a trace followed
>> by a partial stub from a fixme. That's confusing.
>> I don't see your point with someone novice in this area. Could you
> If there's already a stub message in the forwarded function and there's
> really nothing else to do in this function then you can get rid of the
> partial stub, but adding a trace that essentially describes the
> implementation is not useful. It's not like the function is suddenly
> going to do something else.
So I keep the TRACE but remove the "partial stub" part, right ?
The forwarding information is just a way to make things more explicit
but I can deduce it from a log so I can live without it.
More information about the wine-devel