'Pending' patches state

Alexandre Julliard julliard at winehq.org
Wed Mar 28 03:17:25 CDT 2012

Dmitry Timoshkov <dmitry at baikal.ru> writes:

> It's very confusing, and absolutely not clear what is required from the
> patch submitter, especially since *there is no any feedback on the patch*.
> 'Rejected' at least requies some sort of feedback, while 'Pending' doesn't.
> To me 'Pending' looks like a silent case of 'Reject', but without any
> obligation to explain why.
> I find myself on somewhat shaky ground when I see a bunch of my patches
> in the pending state, especially if they already contain the tests and
> main developer in the area I'm changing is Alexandre :).
> Is it possible to get at least some feedback for pending patches? Pretty
> please?

The pending state is feedback. It means that the patch is not clearly
correct, but that it's complicated to articulate exactly why. Like it
says, you should try to make it more convincing, either by simplifying
the patch, or writing a test case.

For instance your patch 84692 says that "tests confirm that", but you
don't say which tests, and there are no new tests or fixed todos in the
patch, so it looks suspicious. Yes, I could dig out the tests myself and
investigate it in detail, but when it gets to that point I usually just
move on to the next patch, hence "pending".

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list