'Pending' patches state
Dmitry Timoshkov
dmitry at baikal.ru
Wed Mar 28 05:09:01 CDT 2012
Alexandre Julliard <julliard at winehq.org> wrote:
> > WM_SHOWWINDOW at the start and at the end of every message sequence
> > means that ShowWindow() should be used to hide and show the window
> > during SetParent call processing.
>
> That's the sort of explanation you should have included in your
> patch, instead of expecting me to dig through the source or the list
> archive to find it. Plus of course some explanation as to why the test
> can't be marked as succeeding despite the change.
There are other things inside of SetParent that break message sequences,
that's why the patches were prepended with a comment explaining what's
wrong with Setparent and saying that it's the first step.
> > Taking an opportunity to discuss other my patches :) I'd like to get
> > a comment to 84685 as well.
>
> Try making it simpler.
Thanks.
--
Dmitry.
More information about the wine-devel
mailing list