[PATCH 2/5] dmusic: Enumerate ports for midi out and midi in devices in EnumPort.

Christian Costa titan.costa at gmail.com
Thu Mar 29 09:18:20 CDT 2012


2012/3/29 Andrew Eikum <aeikum at codeweavers.com>

> On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote:
> > +        midiOutGetDevCapsW(index - 1, &caps, sizeof(caps));
> >     ...
> > +        CoCreateInstance(&CLSID_DirectMusicSynth, NULL,
> CLSCTX_INPROC_SERVER, &IID_IDirectMusicSynth8, (void**)&synth);
> > +        IDirectMusicSynth8_GetPortCaps(synth, port_caps);
>
> Maybe I'm pickier than most people, but I like error checking on these
> sorts of calls. They make it easier to find what is happening when
> something goes terribly and unexpectedly wrong.
>

It's the original code. I decided to keep it in this patch and add error
checking in the patch that comes just after.
I can merge them but I prefer to do things incrementally as much as
possible.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20120329/1a25219d/attachment.html>


More information about the wine-devel mailing list