[Programs] Notepad: sync with ReactOS notepad (2)

Erich E. Hoover ehoover at mines.edu
Sun May 6 12:20:05 CDT 2012

On Sun, May 6, 2012 at 7:49 AM, carlo.bramix at libero.it
<carlo.bramix at libero.it> wrote:
> > thank you for working on this. I think you will improve the chances for
> > your patches to be accepted if you give them individually meaningful
> > names, like
> > ...
> Actually, I followed the tip I read into the wiki of WINE in "Patch submission
> guidelines", so I tried to imitate the style of other patches for WINE and for
> this reason I used an identical title with a progressive number as
> subject.
> ...

What that instruction is meant to say is that patches that are part of
a series (meant to go one after the other) should be numbered
sequentially, but still have a descriptive title.  So, something like:

[PATCH 1/3] notepad.exe: Fix formatting of resource file.
[PATCH 2/3] notepad.exe: Do not use the MSVC reserved keyword "class".
[PATCH 3/3] notepad.exe: Unify find and replace functionality.

Note that these examples are just from scanning your descriptions,
there may be better patch titles that you can use.

> ...
> Well, ReactOS notepad had been imported from WINE long time ago and various
> people did some changes on it and I'm included in them since, in this specific
> case, the status bar implementation had been almost rewritten by me.
> ...

The issue is whether the appropriate guidelines were followed
(http://wiki.winehq.org/CleanRoomGuidelines).  One issue is that Wine
does not allow people that have ever viewed Microsoft source code to
contribute to Wine, but there are other issues.  You'll have to talk
to Alexandre and see how he feels about this specific issue, but if
you've followed all of the guidelines and contribute only your own
changes then he might be ok with your contribution.

Erich Hoover
ehoover at mines.edu

More information about the wine-devel mailing list