[1/2] gdiplus: Measure the passed in string without clipping in order to compute correct Y offset.

Dmitry Timoshkov dmitry at baikal.ru
Mon May 14 08:58:44 CDT 2012


Vincent Povirk <madewokherd at gmail.com> wrote:

> >> > +            GdipMeasureString(graphics, string, length, font, &bounds, format, &bounds, 0, 0);
> >>
> >> You probably shouldn't use the same GpRect* for both parameters there.
> >
> > I don't see any problem with that.
> 
> GdipMeasureString modifies the out parameter and reads the in
> parameter as it goes, and it doesn't account for the possibility that
> it is modifying its own input rectangle.

My tests show that it's not a problem, but I can resend of course
with that change in order to make it less confusing.

-- 
Dmitry.



More information about the wine-devel mailing list