[PATCH 1/5] win16/int21: make found filename uppercase.

Oleksij Rempel bug-track at fisher-privat.net
Wed May 30 08:10:39 CDT 2012


Am 30.05.2012 13:32, schrieb Alexandre Julliard:
> Oleksij Rempel <bug-track at fisher-privat.net> writes:
> 
>> @@ -3961,6 +3962,8 @@ static int INT21_FindNext( CONTEXT *context )
>>              INT21_FindPath = dta->fullPath = NULL;
>>          }
>>          dta->count = n;
>> +        p = dta->filename;
>> +        for ( ; *p; p++) *p = toupper(*p);
> 
> Using toupper is probably not a good idea on OEM codepage strings. Which
> app depends on this?

Probably none. I created this patch by hunting this get_media_id bug. I
even created small windows program calling findfirst/findnext to compare
the output produced by windows and wine.

I just reverted this patch and tested with the program i was working on
and it still works. So no need to apply this patch.

-- 
Regards,
Oleksij



More information about the wine-devel mailing list