Implementation of PNG 'Get Count' and indexed reads...

Max TenEyck Woodbury max at mtew.isa-geek.net
Wed Nov 14 08:00:06 CST 2012


On 11/14/2012 09:38 AM, Dmitry Timoshkov wrote:
> Max TenEyck Woodbury <max at mtew.isa-geek.net> wrote:
> 
>>>> These are currently returning 'not implemented'.
>>>>
>>>> Would it make sense to have 'GetCount' always return '1' and have the
>>>> indexed read simply read in the whole thing?
>>>
>>> Looks like you don't understand what those APIs do. What's that 'the whole
>>> thing'?
>>>
>> Yes, it's the simplest way to stub the whole sequence into doing
>> something useful.  When someone wants to get fancy, they can build a
>> vector of blocks, but that is much more work.  Definitely NOT great, but
>> better than nothing, which is what we have now.
>>
>> 'The whole thing' is the entire image in one swallow.
> 
> Then you need to investigate what should be returned and in which format,
> probably write some tests, read some docs.
> 
Document reading is in progress.  Have the PNG side more or less in
hand,  Need to do the windows side.  Looking for an overview and match
between the two.

So, its just a small mater of code...

Would calculating the total number of 'row' calls and reading each row
as a 'block in turn be an alternate implementation?





More information about the wine-devel mailing list