[PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 3).

[Qian Hong]

Hello,

On Sat, Nov 17, 2012 at 1:03 AM, Alexandre Julliard <julliard at winehq.org> wrote:
> The test fails:
>
> ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok
> usp10.c:1958: Test failed: wgBlank 0000 tmBreakChar 0020
> usp10.c:1958: Test failed: wgBlank 0000 tmBreakChar 0020
> usp10.c:1958: Test failed: wgBlank 0000 tmBreakChar 0020
> usp10.c:1958: Test failed: wgBlank 0000 tmBreakChar 0020

Does the test run before or after patch [2/2] applied?
If the failure is before patch [2/2] then it's expected because I
didn't add todo_wine to [1/2].
I didn't add todo_wine because before [2/2] those test will success
for some fonts on Wine and fail for the other fonts on Wine, and it
seems doesn't make sense to test on only a few fonts.

Is the following solution acceptable?
- Swap the order of patch [1/2] and [2/2], add test cases after fix
the implementation .

Thanks a lot!

--
Regards,
Qian Hong

-
Sent from Ubuntu
http://www.ubuntu.com/