[PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

Ann and Jason Edmeades us at edmeades.me.uk
Mon Nov 19 17:39:21 CST 2012


> IMHO it might be better to use variable names like WINE_xxx for tests
> involving "enumerations" to avoid needlessly altering the environment.
> (not that BAR, FOO or FOOBAR are likely to be already used environment
> variables)
>
> Frédéric
>

Thanks!

We dont really change the environment long term, as the test spawns a
process which has its process modified and runs to completion ie any
changes are thrown away. However, I do agree that if there was an important
environment variable which controlled the shell (in the bug's case it was
BASH_xxx, but could be anything) then it would be wise to leave it in
place, so such a change probably isnt a bad idea anyway.  (I'll make this
change in try 2, as I need to fix the broken NT4 stuff from patch 1 anyway)

Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121119/5fda3b81/attachment.html>


More information about the wine-devel mailing list