[PATCH] cabinet: Turn some ERR into WARN and improved or fix messages.

Christian Costa titan.costa at gmail.com
Tue Nov 27 05:55:44 CST 2012


> -BOOL __cdecl FDIIsCabinet(
>> -       HFDI            hfdi,
>> -       INT_PTR         hf,
>> -       PFDICABINETINFO pfdici)
>> +BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)
>>   {
>>     BOOL rv;
>>     FDI_Int *fdi = get_fdi_ptr( hfdi );
>> @@ -749,13 +746,13 @@ BOOL __cdecl FDIIsCabinet(
>>     if (!fdi) return FALSE;
>>       if (!hf) {
>> -    ERR("(!hf)!\n");
>> +    WARN("No file handle\n");
>>       SetLastError(ERROR_INVALID_**HANDLE);
>>       return FALSE;
>>     }
>>       if (!pfdici) {
>> -    ERR("(!pfdici)!\n");
>> +    WARN("No cab info pointer\n");
>>       SetLastError(ERROR_BAD_**ARGUMENTS);
>>       return FALSE;
>>     }
>>
> This call already has a TRACE earlier, I don't see a point in tracing
> input parameters multiple times.
>
>>
>>
Indeed. That would be better to remove them. Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121127/947d97c5/attachment.html>


More information about the wine-devel mailing list