[PATCH] rpcrt4: wait_async_request: return error if we received an error

Jacek Caban jacek at codeweavers.com
Tue Oct 2 06:19:37 CDT 2012

Hi Marcus,

On 10/01/12 23:00, Marcus Meissner wrote:
> Hi,
> Various coverity issues complain about user-after-free scenarios,
> all involving this code path.
> I strongly think if call_ret signals error, we also need to return
> an error condition to avoid the callers from proceeding as if nothing
> happened.
> Second reiteration with Jaceks comment applied

Sorry for not catching this later, I was concentrated on your comment
instead of the code, but the important thing is that true call_ret means
success (and wininet doing request asynchronously is signalled as an
error). It means that in this case we want to return RPC_S_OK. What is
the exact problem?


More information about the wine-devel mailing list