[PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.

Jacek Caban jacek at codeweavers.com
Wed Oct 3 03:23:31 CDT 2012

On 10/02/12 23:02, Erich E. Hoover wrote:
> If a cleanup occurs because HTML Help window creation fails then
> list_remove() causes a crash, since the window was never added to the
> window list.  The attached patch fixes this issue, allowing safe
> reloading of files (needed for part 2).

This looks like a hack. It would be better to have always valid list
entry (if this really can't be added to the list earlier, you may always
initialize it by list_init) or make sure to not call ReleaseHelpViewer
before HHInfo is fully initialized.


More information about the wine-devel mailing list