[PATCH 1/5] include: Added definitions used by GetFileInformationByHandleEx.

Dmitry Timoshkov dmitry at baikal.ru
Tue Oct 9 21:40:32 CDT 2012


"Vincas Miliūnas" <vincas.miliunas at gmail.com> wrote:

> +typedef struct _FILE_ID_DESCRIPTOR {
> +    DWORD        dwSize;
> +    FILE_ID_TYPE Type;
> +    union {
> +        LARGE_INTEGER   FileId;
> +        GUID            ObjectId;
> +#if (_WIN32_WINNT >= 0x0602)
> +        EXT_FILE_ID_128 ExtendedFileId;
> +#endif
> +    } DUMMYUNIONNAME;
> +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR;

The '#if/#endif' part is useless in Wine (here in in other places as well).
Also you should add new structures in every patch that needs them, one by
one, not adding a bunch of not used stuff at once.

P.S.
In PSDK 7.1 (targeting Windows 7) some of the structures look different.
Where does this come from? 

-- 
Dmitry.



More information about the wine-devel mailing list