[PATCH 5/5] kernel32: Added implementation for OpenFileById.

Dmitry Timoshkov dmitry at baikal.ru
Tue Oct 9 21:45:27 CDT 2012


"Vincas Miliūnas" <vincas.miliunas at gmail.com> wrote:

> +    objectName.Buffer             = (WCHAR *)&lpFileID->DUMMYUNIONNAME.FileId;

This doesn't look right.

> +    if (status)
> +    {
> +        SetLastError( RtlNtStatusToDosError( status ) );
> +        return INVALID_HANDLE_VALUE;
> +    }
> +    else if (!result)
> +    {
> +        return INVALID_HANDLE_VALUE;
> +    }
> +    else
> +    {
> +        return result;
> +    }

It looks like some braces and all 'else' statements may go.

-- 
Dmitry.



More information about the wine-devel mailing list