d3dx9_36 [patch 1/3]: Fix the case out = in for D3DXSHRotateZ

Nozomi Kodama nozomi.kodama at yahoo.com
Wed Oct 17 01:35:45 CDT 2012


My bad.

My patch pass the tests but not yours. Can you check these facts?

Nozomi




 
>Hi Nozomi,
>
>the huge arrays, the loop, it looks a bit ugly. Your implementation makes the D3DXSHRotateZ function a >bit more compatible. What comes into my mind is:
>D3DXSHRotateZ(out, y, 1,25f, in);
>D3DXSHRotateZ(out, y, 1,25f, out);
>D3DXSHRotateZ(out, y, 1,25f, &out[x]); // x ... 1 - y * y
>D3DXSHRotateZ(&out[x], y, 1,25f, out); // x ... 1 - y * y
>
>Do the last 2 also work and are they producing the same values as native?
>
>Attached is a simple hack to succeed your test, it has some major stuff which needs to be fixed first, but >nevertheless, please have a look. I think the implementation could be a lot smaller and faster. What do you >think? I'd like to hear your opinion, before you try to send a patch.

>+FLOAT * WINAPI D3DXSHRotateZ(FLOAT *out, UINT order,  FLOAT angle, CONST FLOAT *in)
>There is a double space after "order,".
>
>Cheers
>Rico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121017/03158838/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-tests-for-D3DXSHRotateZ.patch
Type: application/octet-stream
Size: 9504 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121017/03158838/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-the-case-out-in-for-D3DXSHRotateZ.patch
Type: application/octet-stream
Size: 5912 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20121017/03158838/attachment-0003.obj>


More information about the wine-devel mailing list