[PATCH 3/6] dsound: create a primary_pwfx separately from pwfx
m.b.lankhorst at gmail.com
Fri Oct 19 17:13:08 CDT 2012
Op 19-10-12 15:29, Andrew Eikum schreef:
> Patches 1 and 2 in this series look fine.
> I have a series of patches similar to this one in my dsound
> multichannel branch. This patch seems to do too much at once.
> When I did this cleanup, I split it up into four patches:
> 1) Allocate the device format in the Device struct
> 2) Load the default format from the IAC, not hard-coded in dsound
> 3) Put SetFormat() calls into their own WFX that we don't really care
> 4) Always use WAVE_FORMAT_EXTENSIBLE for the device format
3 of 6 does essentially the step you call #4 and #2, other steps is just fixes I already have in my tree.
Tested quite extensively too
The other steps I have already done in a followup series, except #1, it's unneeded.
It also breaks device->pwfx = NULL in the initial case, which is nice to see if something
depends on the new format before changing over is complete. This would otherwise
be very hardto detect.
I'm surprised you call #2 a separate step since from what I gathered about
mmdevapi is that until win7 sp1 it only supported 1 rate, and we don't
implement the rate changing extension yet, so the whole popular format
testing was pointless to begin with.
Is there anything *technically* wrong with the patch series though?
More information about the wine-devel