[PATCH 4/6] dsound: Use event based threads

Andrew Eikum aeikum at codeweavers.com
Mon Oct 22 10:32:27 CDT 2012

On Fri, Oct 19, 2012 at 11:33:22PM +0200, Maarten Lankhorst wrote:
> Op 19-10-12 15:40, Andrew Eikum schreef:
> > I'm a big fan of error checking (or at least reporting), so these
> > unchecked calls make me nervous. They'll probably never fail, but if
> > they do, I think they should fail loudly.
> >
> Erm, dsound at this point will be worse off if you perform error reporting here than fail silently.
> It leaves a bigger mess since ReopenDevice is not atomic right now..

What I meant by "reporting" was write a WARN or something. Then we
know something wrong happened even if we don't have the correct driver
channel enabled.


More information about the wine-devel mailing list