[PATCH 1/5] d3dx9_36: Implement D3DXFileCreate.
titan.costa at gmail.com
Mon Oct 22 16:19:39 CDT 2012
Le 22/10/2012 22:55, Jacek Caban a écrit :
> On 10/22/12 10:13 PM, Rico Schüller wrote:
>> On 22.10.2012 21:27, Christian Costa wrote:
>>> +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> REFIID riid, LPVOID *ret_iface)
>>> + ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
>>> + ID3DXFileImpl* object;
>> Please be a bit more consistent across your patch... There are a lot
> more occurrences where you mix both usages.
> His usage seems natural when you think about using 'This' as analogy to
> 'this' in C++ implementation. That said, it's really a matter of taste,
> but such analogy feels natural when you work with COM. And by that logic,
> the patch is consistent. It uses 'object' as name of global function,
> which is not member of any class-like thing.
> Christian, there were some informal attempts to limit usage of stuff like
> LPVOID (and really any LP* types). It would be nice if you could avoid it
> in your patches.
I don't mind change it but just by curiosity what's the reason? MSDN
uses it a lot.
By the way is there a page on the wiki that deals with coding
style/rules with mandatory & preferred stuff?
If not I can create one and put what I'm aware of.
More information about the wine-devel