[PATCH 1/5] d3dx9_36: Implement D3DXFileCreate. (try 3)

Dmitry Timoshkov dmitry at baikal.ru
Wed Oct 24 10:53:29 CDT 2012


Christian Costa <titan.costa at gmail.com> wrote:

> Well, that would have been better to spot this *much* earlier.
> 
> More generally about coding style or rules, that would be *much* better to
> write a wiki page about this and point to it
> along with code style comments. I don't mind following rules or adopt "nice
> to do" but I cannot guess the difference
> between formal rules, informal ones and personal tastes. It would be better
> for everyone and focus the review
> on technical stuff. And this is not the first time I talk about such a page.

Handling out of memory errors, avoiding useless spam to the console, avoiding
blanket memset() calls are not the coding style things and they are not specific
to Wine or any other project, this is basic things a programmers needs to follow
in general IMHO.

-- 
Dmitry.



More information about the wine-devel mailing list