dplayx: Reorder some code to avoid memory leaks (coverity)
Rico Schüller
kgbricola at web.de
Mon Oct 29 03:20:09 CDT 2012
On 28.10.2012 16:13, André Hentschel wrote:
> - lpGData->lpRemoteData = lpNewData;
> + lpGData->lpRemoteData = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof( dwDataSize ) );
> + CopyMemory( lpGData->lpRemoteData, lpData, dwDataSize );
> lpGData->dwRemoteDataSize = dwDataSize;
> - lpPData->lpRemoteData = lpNewData;
> + lpPData->lpRemoteData = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof( dwDataSize ) );
> + CopyMemory( lpPData->lpRemoteData, lpData, dwDataSize );
> lpPData->dwRemoteDataSize = dwDataSize;
Is the HEAP_ZERO_MEMORY really needed? You may kill that too while you
change those lines.
Cheers
Rico
More information about the wine-devel
mailing list