[PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

Alexandre Julliard julliard at winehq.org
Mon Sep 3 04:34:11 CDT 2012

Alex Henrie <alexhenrie24 at gmail.com> writes:

> I was asked to split this patch up, so I did. The complaint about the
> last version was "You are still overflowing the source." I have not
> been able to find any test case that my implementation handled
> incorrectly, however, I did find that (*src == 0 && srclen < 0) will
> never evaluate to true, so I removed this if statement from the code. I
> also changed example #2 in the tests to be slightly more stringent, but
> the last patch would also have passed.
> If this patch series is rejected, please show me a test case that
> demonstrates what I am doing wrong.

You don't have a single test with an explicit source length, so
obviously you are not going to find problems in that area. Like I said,
you need a lot more tests.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list