[PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

Alexandre Julliard julliard at winehq.org
Mon Sep 3 10:26:39 CDT 2012

Alex Henrie <alexhenrie24 at gmail.com> writes:

> 2012/9/3 Alexandre Julliard <julliard at winehq.org>:
>> You don't have a single test with an explicit source length, so
>> obviously you are not going to find problems in that area. Like I said,
>> you need a lot more tests.
> example_2 already tests an explicit source length. In all the other
> examples srclen = strlen(src) + 1, see
> http://source.winehq.org/git/wine.git/blob/2097c5ddb6bec24cf4bbd440a6f401cfa67007f0:/dlls/kernel32/locale.c#l1929
> So again, what specific additional test, or what specific change to
> the existing tests, do you want to see?

Think about what the code is doing, and how to test it. In particular
spend some time thinking about the source length parameter.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list