[PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation
jimportal at gmail.com
Mon Sep 10 10:27:57 CDT 2012
I've sent a patch set that I need some help testing. The first four
in the series should be fine as they don't change anything specific to
a particular platform. The last one however makes some changes which
are platform specific (affects Linux, Apple, and various BSDs). I've
tested the Linux code but I do not have an Apple, for example, to test
that code. While the code looks good to me and is is largely based
off of code removed from fill_cpu_info(), it is still worth some
concern that it hasn't seen any real testing. If you have a Mac or
BSD, I would be grateful if you could try the patches out to make sure
things are working as expected. You'll find a few more details in the
commit message http://source.winehq.org/patches/data/89698 .
Also of concern is that the testbot seems to have only one processor.
This results in most of the tests added in
http://source.winehq.org/patches/data/89697 being skipped. So testbot
doesn't seem that helpful for this test.
As for the implementation of the test itself, would it be better to
use broken() and just test Wine for the Win7 behavior? From my
testing, the test as is works for XP, Win7, and Wine with my patch
set. If we can write the test to work everywhere, don't use broken()?
There are more details in the patch itself so please have a look and
let me know what you think.
More information about the wine-devel