[4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

Henri Verbeet hverbeet at gmail.com
Mon Sep 24 05:07:44 CDT 2012


On 23 September 2012 22:40, Ričardas Barkauskas
<rbarkauskas at codeweavers.com> wrote:
>
> +struct refresh_rates {
Formatting.

> +struct refresh_rates refresh_list[] =
This should be static const.

> +    ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr);
"returned".

> +    for (i = 0; i < sizeof(refresh_list)/sizeof(struct refresh_rates); i++)
I generally prefer "sizeof(*refresh_list)", or perhaps
"sizeof(refresh_list[0])" over "sizeof(struct refresh_rates)" in this
kind of situation.

> +                "Numerator %d is %d.\n", i, result_desc.BufferDesc.RefreshRate.Numerator);
These are unsigned variables.



More information about the wine-devel mailing list