gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame.

Vincent Povirk madewokherd at
Thu Sep 27 09:52:07 CDT 2012

> @@ -3898,7 +3894,7 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d
>          return Ok;
>      }
> -    IStream_Release(stream);
> +    IStream_Release(image->stream);
>      return stat;
>  }

I don't think it's necessary to AddRef/Release the stream anymore in
GdipImageSelectActiveFrame. Creating the new image and freeing the old
one will update the refcount as necessary. And it's a bit confusing
since technically the current image->stream is released by
free_image_data then overwritten (with the same value, fortunately) by
copying new_image to image.

Looks good otherwise.

More information about the wine-devel mailing list