[3/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution

[Eric Pouech]

Le 08/04/2013 16:03, Nikolay Sivov a écrit :
>
>
>
> On Mon, Apr 8, 2013 at 4:47 PM, Hugh McMaster 
> <hugh.mcmaster at masterindexing.com 
> <mailto:hugh.mcmaster at masterindexing.com>> wrote:
>
>     From: Nikolay Sivov [mailto:bunglehead at gmail.com
>     <mailto:bunglehead at gmail.com>]
>     Sent: Monday, 8 April 2013 11:08 PM
>     To: wine-devel; Hugh McMaster
>     Subject: Re: [3/13] wineconsole and kernel32: set
>     GetLargestConsoleWindowSize based on screen resolution
>
>     >On Mon, Apr 8, 2013 at 3:53 PM, Hugh McMaster
>     <hugh.mcmaster at masterindexing.com
>     <mailto:hugh.mcmaster at masterindexing.com>> wrote:
>     >This file recreates most, if not all, of the source found in
>     dlls/advapi32/registry.c in dlls/kernel32. It provides registry
>     functionality.
>
>
>     >>Why do you need this?
>     If I remember correctly, there were several function dependencies
>     for the registry implementation I worked on.  I'm not sure of the
>     exact number, but will work this out.
>
>     What should I do then, though? Should I isolate the functions I
>     need into a separate file? Or should the dlls/advapi32/registry.c
>     be linked into the dlls/kernel32/Makefile.in?
>
>
> If you need to access registry from kernel32 you'll need to use ntdll 
> calls directly.
>
>
>     >>(not to mention that you can't just duplicate it like that)
>     I'm not sure what you mean. The source remains correctly
>     attributed as in the original.
>
>
> This functionality belongs to advapi32. Do you really need anything 
> more than ntdll calls provide?
>
>
and on top of that, using registry as a way to exchange information 
between wineconsole and kernel is not the right thing to do
the correct way is to:
- enhance the wine server protocol to grab max win size in kernel32 from 
wine server
- enhance wineconsole to set the max wine size into wine server (and to 
recompute it when there's a screen resize event)

A+
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130408/b51567c0/attachment.html>