[PATCH 8/8] wined3d: Skip non-textureable formats in check_fbo_compat().

Henri Verbeet hverbeet at gmail.com
Wed Apr 10 11:46:12 CDT 2013


On 10 April 2013 17:53, Matteo Bruni <matteo.mystral at gmail.com> wrote:
> The idea is that, since check_fbo_compat() creates a texture of the
> specified format to attach it to a test FBO and verify that it works
> correctly, it doesn't make sense to even try if the format is
> non-texturable.
>
Well, we do check for format->glInternal in
init_format_fbo_compat_info(), this would mostly affect formats like
WINED3DFMT_P8_UINT or WINED3DFMT_UYVY that don't have
WINED3DFMT_FLAG_TEXTURE set, but do have an internal format. I'm not
sure we necessarily want to prevent doing e.g. FBO blits on those, or
that we'd gain anything from not testing those.



More information about the wine-devel mailing list