[PATCH 2/2] wined3d: Store ps 1.4 texture types in ps_compile_args

Henri Verbeet hverbeet at gmail.com
Thu Apr 11 06:41:07 CDT 2013


On 11 April 2013 11:40, Stefan Dösinger <stefan at codeweavers.com> wrote:
> +        for (i = 0; i < 6; ++i)
> +        {
This could probably do with an appropriate constant.

> +enum shader_tex_types
> +{
> +    shader_tex_2d       = 0,
> +    shader_tex_3d       = 1,
> +    shader_tex_cube     = 2,
> +};
Please use uppercase for enum elements. Some "wined3d" prefixes
probably wouldn't hurt either, although I guess it doesn't matter so
much for things that are only used internally.



More information about the wine-devel mailing list