[PATCH 3/3]vbscript: Implemented builtin function CBool

Zhan Jianyu nasa4836 at gmail.com
Thu Apr 18 06:18:02 CDT 2013


On Thu, Apr 18, 2013 at 6:24 PM, Jacek Caban <jacek at codeweavers.com> wrote:
>
> I don't think converting to double is a good idea here. Why don't you do
> conversions directly to BOOL for all cases?
>
  My fisrt thought on this is to convert all type to double, and then at last
  I just do one-time comparision, to avoid comparision in every Case.


> Are you sure you want to return string type here? I'd expect a bool value
> (of type VT_BOOL) here...
>
>  }

  Oh, I'm misguided by the doc I referred to ... I will fix this.






--

Regards,
Zhan Jianyu



More information about the wine-devel mailing list