Compiler warnings on Debian kfreebsd-i386

[Ken Sharp]

On 08/08/13 21:28, Charles Davis wrote:
>
> On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote:
>
>> Some interesting, some not:
>>
>> /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ defined but not used [-Wunused-function]
>> /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: ‘find_owning_pid’ defined but not used [-Wunused-function]
> I have a patch to fix those (and another one to fix them on Mac OS), but there's a bunch of patches ahead of it in my queue. Also, the patch was designed for standard FreeBSD (it needs libprocstat), so I'm not sure how well it will work on GNU/kFreeBSD. I've attached both patches so you can test it. N.B. the Mac OS patch needs to be applied first--it was developed first, and it implements the guts of the GetExtended*Table functions that actually call those functions. Also, you'll need to run autoreconf(1) after applying: the patches contain changes to configure.ac, but not configure or include/config.h.in.
>
>> /home/ken/wine-git/dlls/ntdll/directory.c: In function ‘wine_getdirentries’:
>> /home/ken/wine-git/dlls/ntdll/directory.c:1710:5: warning: passing argument 4 of ‘getdirentries’ from incompatible pointer type [enabled by default]
>> In file included from /home/ken/wine-git/dlls/ntdll/directory.c:29:0:
>> /usr/include/dirent.h:313:18: note: expected ‘__off_t * __restrict__’ but argument is of type ‘long int *’
> This one has to do with the actual getdirentries(2) prototype:
>
> int getdirentries(int, char *, int, long *);
>
> glibc's prototype is broken. It really is a 'long *', not an 'off_t *' (don't believe me? Go read the syscalls.master file in the kernel source). Or, maybe they're aware of this, and glibc's getdirentries(2) stub extends the 32-bit long (on a 32-bit system) into an off_t--in which case, we'll need a configure check for this.
>
> Chip
>

All looks good here. No warnings, no failures.

$ uname -srmvpio
GNU/kFreeBSD 9.0-2-686 #0 Sun Jun 23 17:53:03 UTC 2013 i386 i386 
Intel(R) Pentium(R) 4 CPU 3.00GHz GNU/kFreeBSD

$ ~/wine32/wine --version
wine-1.7.0

There are a few test failures but I don't think that they are related 
(fixmes).

fixme:iphlpapi:SetTcpEntry (pTcpRow 0x33fcc8): stub
iphlpapi.c:855: Test failed: got 0, expected 87
fixme:iphlpapi:SetTcpEntry (pTcpRow 0x33fcc8): stub
iphlpapi.c:859: Test failed: got 0, expected 317
fixme:iphlpapi:NotifyAddrChange (Handle 0x33fcb4, overlapped 0x33fcb8): stub
iphlpapi.c:1055: Test failed: GetLastError returned 203, expected 
ERROR_IO_PENDING
fixme:iphlpapi:CancelIPChangeNotify (overlapped 0x33fcb8): stub
iphlpapi.c:1057: Test failed: CancelIPChangeNotify returned FALSE, 
expected TRUE
fixme:iphlpapi:CancelIPChangeNotify (overlapped 0x33fcb8): stub
fixme:iphlpapi:NotifyAddrChange (Handle 0x33fcb4, overlapped 0x33fcb8): stub
iphlpapi.c:1068: Test failed: NotifyAddrChange returned invalid file handle
fixme:iphlpapi:CancelIPChangeNotify (overlapped 0x33fcb8): stub
iphlpapi.c:1074: Test failed: CancelIPChangeNotify returned FALSE, 
expected TRUE