oledb32: Add IDataSourceLocator support (try 4)
Nikolay Sivov
bunglehead at gmail.com
Wed Aug 21 00:24:14 CDT 2013
On 8/21/2013 09:15, Alistair Leslie-Hughes wrote:
> Hi,
> Use helper functions for memory
>
>
> Changelog:
> oledb32: Add IDataSourceLocator support
>
>
> Best Regards
> Alistair Leslie-Hughes
It looks okay, but I suggest to fix a naming:
> +typedef struct DataSourceImpl
> +{
> + IDataSourceLocator IDataSourceLocator_iface;
> + LONG ref;
> +
> +} DataSourceImpl;
> +static HRESULT WINAPI datasource_QueryInterface(IDataSourceLocator *iface, REFIID riid, void **ppvoid)
etc.
IDataSource is another interface, and it's confusing to name locator
after it - dslocator_* naming used in CF is
short enough and descriptive to use it everywhere.
More information about the wine-devel
mailing list