[PATCH 3/5] ddraw: Change surface pitch before width.

[Henri Verbeet]

On 13 December 2013 14:50, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
>
> Am 13.12.2013 um 14:18 schrieb Henri Verbeet:
>> On its own this patch is perhaps innocent enough, but it looks like
>> this is supposed to make 4/5 safe, in which case that patch ends up
>> depending on a somewhat obscure implementation detail. I think it may
>> be better to merge wined3d_surface_set_mem() into
>> wined3d_surface_update_desc(), at least as far as the public interface
>> is concerned.
> The result would be pretty close to ddraw_suface::SetSufaceDesc, and I'm not particularly happy with that design. We'd have to provide similar constraints about which properties must be set together and which properties can remain untouched.
>
I think we'd want the callers to always specify everything, but only
do the more expensive things like e.g. resource_unload() when
required.