[PATCH] dsound: copy program parameters in SetFormat

Andrew Eikum aeikum at codeweavers.com
Wed Feb 13 10:08:12 CST 2013

On Mon, Feb 11, 2013 at 02:06:42PM +0100, Maarten Lankhorst wrote:
> Fixes bug #32312, apparently some programs depend on the format it specifies being returned.
> Just set wBitsPerSample, nSamplesPerSec and nChannels to make those applications happy.

The patch seems fine, but can you add some tests for this so we can
nail down exactly what we should be taking from the SetFormat format?
E.g. should we just do "device->primary_fmt = CopyFormat(passed_fmt)"
in all cases, or can you find a case where the GetFormat() result is

FYI, your patch applies with an offset and the Wine patch tracker
didn't like this:
> --- a/dlls/dsound/primary.c	
> +++ a/dlls/dsound/primary.c	
but git-am imported the raw mail file just fine.


More information about the wine-devel mailing list