[3/4] windowscodecs: Implement CreateBitmapFromMemory.

Vincent Povirk madewokherd at gmail.com
Wed Jan 2 23:19:56 CST 2013


On Wed, Jan 2, 2013 at 11:42 PM, Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> It's better to actually check return value of IWICBitmapLock_GetDataPointer
> before memecpy(), or if that's not supposed to fail drop 'hr' assignment.

Whoops, good catch. (I don't think it can fail, but I didn't mean to
make that assumption.)

I guess I prefer to keep interfaces as simple as possible even if it
means writing more code? I'd consider writing a helper function, but
none of the other methods would use it.



More information about the wine-devel mailing list