Patchsets that need review by experienced Wine Developers

[Marcus Meissner]

On Thu, Jan 03, 2013 at 05:22:14PM -0500, jordan wrote:
> Hi,
> 
> I have been experimenting with some patchsets for Wine -> based on an
> implementation of Wine originally developed By Muse Research.  It has
> improved support for a bunch of stuff, fixes (most) bottlenecks for
> Linux proaudio folks making use of Wine + Jack, and also contains some
> bug fixes for wine (that may or may not be acceptable to wine-devs.)
> 
> I have a project that now lives on SF.net, but has been running for
> months now, on my machine(s), locally. It's called L-ProAudio, and the
> version of wine (L_pa-Wine) is geared towards proaudio users. We also
> have support in 1 linux application ~ which now properly handles the
> new method of mapping win/prio -> linux/prio. Some of the patchset
> fixes synchronization issues (with jack), disk geomtery-io-syscl,
> fixes rendering bugs in VSTs (probably other apps too) and a bunch of
> other improvements (geared for proaudio users).
> 
> L_ProAudio SF.net Page: https://sourceforge.net/projects/l-proaudio/
> 
>  -> Wine-L_Proaudio_Arch_n_patches.tar.gz contains a pkgbuild for
> Archlinux (like gentoo' ebuild) + all patches (and probably one or two
> others, not used in my builds).
> 
> But please note: this is NOT a fork of Wine. It is necessary for me to
> be able to run the applications that i want with Wine. I am just
> carrying patchwork and re-basing it, as time passes. But i decided to
> release it - since it benefits the larger community who uses this
> stuff (greatly).
> 
> note 2: I am posting, in order to shed light on any improvements/bug
> fixes that _might_ be suitable for upstream. ~ If so, once a given
> stable release of Wine is issued, I would then be able to remove them
> from my patchset, minimizing duplicate efforts, among other things.
> 
> The original patches/sources (that i have based my version on, are
> found here: http://www.museresearch.com/support/receptor-faq.php
> 
> ...at the bottom of the page / last link:
> http://www.museresearch.com/support/receptor-faq.php
> 
> these patches fix Wine problems (in most areas) for people using
> linux(-rt) + jack + ProAudio ... but may have other benefits/bug-fixes
> for wine. It's Gpl'd (obviously), so it would be worthwhile to have a
> look anyway. - didn't include every patch (some of them aren't of
> interest to me, outdated, etc).

I looked over them briefly.

0005-Expand-dos-has-entropy-in-order-to-make-collision-le.patch
	Not sure why this is needed?

0010-If-a-child-of-the-window-being-disabled-is-the-captu.patch
	a user32.EnableWindow 2008 patch ... is it still needed for you,
	as quite some enhancements have happened...

	Would need review (likely from julliard or other user32 guru)
	and testcases.

0012-ntdll-Use-pipes-for-synchronization-objects.patch
0050-pipe-check-and-thread-safe-read.patch

	A new synchronization method using UNIX pipe(2)s.
	This is definitely not going in as is...

	It would be interesting to know what deficit in regular Wine is
	fixed by it. wineserver overhead?

0023-improve-IoRegisterDeviceInterface.patch

	Remove the MUSE specific fixmes and use the same FIXME() style
	for stub parameters as in the other FIXME()s. Then
	its ready for wine-patches I would say.

0025-Add-stub-for-IoSetDeviceInterfaceState.patch
	Use same FIXME() style as used for other stub functions, then
	ready for submission.

0027-Add-stub-for-PoSetPowerState.patch
	Good for submission as-is.

0033-overridable-default-filesystem-type.patch
	Not submittable as-is ...
	It would be good to know the reason and/or what MUSE expects.

0044-get-windows-label-from-registry.patch
	Smells like the wrong place to do it. Perhaps mountmgr.sys,
	but perhaps different.
	Also unclear if Alexandre likes it.

0052-NI-drag-and-drop.patch
	Looks already good for submission to me.


0054-set-realtime-priority-without-wineserver.patch
wine-rt-101107.patch
	Needs design and discussion... So far a RT solution
	was not accepted for Wine yet.


0061-fix-broken-cross-compiled-winegcc.patch
0063-disable-winedbg-auto-crash-dialog.patch
	local hacks

0062-disable-crashing-alpha-bitmaps-for-gdb.patch
	Seems like a mistaken patch that was needed as we had
	the old DIB sections.

	gdb would have accepted "continue" here.

	Should not be necessary anymore these days with the 
	DIBENGINE.

add-implementation-setProcessWorkingSetSize.patch
	Might be submittable as-is. 

	Might need autoconf checks for non-Linux.

Fix-disk-geometry-ioctl.patch
	Alexandre usually does not like override files
	like this unless necessary.

	What is actually expected? you mentioned rendering issues?

fix-obscured-windows.patch
	Hmm, needs user32 windowing guru review.


menu-border-color.patch
	If this is not just a hack, could be submitted as-is.


prevent-runtime-conntrack-changes.patch
	A Linux kernel patch? Likely wrong here.