Truncate MIDI SysEx messages after termination byte

Johannes Kroll jkroll at lavabit.com
Wed Jan 9 18:09:45 CST 2013


On Thu, 10 Jan 2013 01:05:28 +0100
Johannes Kroll <jkroll at lavabit.com> wrote:

> On Thu, 10 Jan 2013 00:38:06 +0100
> Christian Costa <titan.costa at gmail.com> wrote:
> 
> 
> > After a better look the changes seem correct.
> > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough.
> 
> Without the buffer length check, there would be a buffer overflow when
> an application tries to send a SysEx without an F7 byte. 

I meant a read past the end of the buffer of course, not an overflow.




More information about the wine-devel mailing list