[PATCH 1/2] d3d9: Return D3D_OK from the palette setters

Henri Verbeet hverbeet at gmail.com
Fri Jan 11 06:05:01 CST 2013

On 11 January 2013 12:49, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> I don't think it's worth a big argument and resent the patches without
> it, but IMO zeroing output structures in the tests makes sense.
> Ideally we'd have a test that explicitly tests if GetDeviceCaps clears
> the structure. All other tests should clear the structure to avoid
> randomness - there might be a third d3d9 implementation where the
> author forgot to clear the structure.
Perhaps if we were explicitly testing GetDeviceCaps(), but it's
probably basic enough that it's not needed. Everywhere else, the same
reasoning applies as for not checking that e.g. HeapAlloc() succeeds
in tests.

More information about the wine-devel mailing list