include: flesh out d3d11.idl (try 2)

Dmitry Timoshkov dmitry at baikal.ru
Fri Jan 11 22:42:00 CST 2013


Austin English <austinenglish at gmail.com> wrote:

> >> +/* Forward declarations */
> >
> > You've copied too much from the PSDK version, better leave it to someone
> > else, and do it step by step when particular functionality gets implemented.
> 
> The forward declarations are necessary due to the convoluted nature of
> the interfaces. My end goal is to add a stub for D3D11CreateDevice,
> which fixes http://bugs.winehq.org/show_bug.cgi?id=32520 (so users
> don't have to disable d3d11). However, adding a stub requires
> ID3D11Device and ID3D11DeviceContext, which are 158 and 413 lines
> respectively. If I only add what is needed, it saves ~600 lines (1650
> vs 2230), so I went ahead and added the rest.

I meant that you not only copied structures, declarations and definitions
without even slight attempt to make them a bit different from PSDK, but
also copied the comments. That approach clearly is not acceptable.

-- 
Dmitry.



More information about the wine-devel mailing list