[PATCH] advapi32: add RegSetKeyValue{A,W}
Nikolay Sivov
bunglehead at gmail.com
Sun Jan 13 05:14:59 CST 2013
On 1/13/2013 09:27, danielfsantos at att.net wrote:
> Adds RegSetKeyValue{A,W} to advapi32.dll
> Refactors RegSetValue{A,W} to call RegSetKeyValue{A,W}
> Fixes bug #32711
> ---
> dlls/advapi32/advapi32.spec | 4 +-
> dlls/advapi32/registry.c | 81 +++++++++++++++++++++++++++++++++----------
> 2 files changed, 64 insertions(+), 21 deletions(-)
>
> diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec
> index 21357fa..336518b 100644
> --- a/dlls/advapi32/advapi32.spec
> +++ b/dlls/advapi32/advapi32.spec
> @@ -645,8 +645,8 @@
> # @ stub RegSaveKeyExW
> @ stdcall RegSaveKeyW(long ptr ptr)
> @ stdcall RegSetKeySecurity(long long ptr)
> -# @ stub RegSetKeyValueA
> -# @ stub RegSetKeyValueW
> +@ stdcall RegSetKeyValueA(long str str long ptr long)
> +@ stdcall RegSetKeyValueW(long str str long ptr long)
This should use wstr.
> +LSTATUS WINAPI RegSetValueW( HKEY hkey, LPCWSTR name, DWORD type, LPCWSTR data, DWORD count )
> +{
> + return RegSetKeyValueW(hkey, name, NULL, type, data, count);
> +}
Don't use tabs please.
And as I said in bug comment this needs tests.
More information about the wine-devel
mailing list