Truncate MIDI SysEx messages after termination byte

Joerg-Cyril.Hoehle at Joerg-Cyril.Hoehle at
Mon Jan 14 11:29:23 CST 2013


Christian Costa wrote:
>I took a look at the
>alsa code and this code simply does not do what it is supposed to.
I also looked at it today and noted those bogus lines you quote. Needs
a patch (+ fix memory leak).

However, Johannes' change is presumably different, as he wants to
scan the buffer contents for a F7 terminator and ignore subsequent
bytes.  If I were to decide, I'd like to see more supporting evidence.

I'd appreciate if Johannes would open a bug report and attach some WINEDEBUG=+midi,+mmdevapi,+alsa,+winmm,+driver,+tid,+timestamp logs to bugzilla,
much like bug #26928.
Having some logs with *complete* SysEx contents helps.

There's also a "closed as abandoned" bug about microKORG
which might be of interest to Johannes.

	Jörg Höhle

More information about the wine-devel mailing list