Truncate MIDI SysEx messages after termination byte

Christian Costa titan.costa at
Mon Jan 14 12:03:23 CST 2013

2013/1/14  <Joerg-Cyril.Hoehle at>:
> Hi,
> Christian Costa wrote:
>>I took a look at the
>>alsa code and this code simply does not do what it is supposed to.
> I also looked at it today and noted those bogus lines you quote. Needs
> a patch (+ fix memory leak).

I will take a look at it and send a patch unless someone plan to do it.
I will not  be able to test with my 2 HW midi devices right now so I need
someone to test it. That would be good to enter a bug report for that.
Johannes, can you do that?

> However, Johannes' change is presumably different, as he wants to
> scan the buffer contents for a F7 terminator and ignore subsequent
> bytes.  If I were to decide, I'd like to see more supporting evidence.

In the case the first by is F0 and the last one is F7, the code passes
a uninitialized buffer to the alsa function with a wrong terminating
byte F0 inserted which
is even worst because it opens a new sys ex sequence without end.
The Johanness patch prevents this case to happend by making last byte to be F7.


More information about the wine-devel mailing list