Patches for winspool.drv and other locations

Detlef Riekenberg wine.dev at web.de
Mon Jan 14 15:46:30 CST 2013


Hi Tatyana

Welcome to Wine.

Wine has a test suite to make sure, that new code is correct.


Example, what you never tested:
> -    if(!pDeviceName) {
> +    if(!pDeviceName && !*pDeviceName) {

Your code will crash, when pDeviceName is NULL.
I expect, you want to use a logical OR, but i did not test such a code change.


--
By by ... Detlef



More information about the wine-devel mailing list