windowscodecs: Implement GetThumbnail in the ICO frame decoder.

Dmitry Timoshkov dmitry at baikal.ru
Wed Jan 30 04:52:35 CST 2013


Hans Leidekker <hans at codeweavers.com> wrote:

> >  static HRESULT WINAPI IcoFrameDecode_GetThumbnail(IWICBitmapFrameDecode *iface,
> >      IWICBitmapSource **ppIThumbnail)
> >  {
> > -    FIXME("(%p,%p)\n", iface, ppIThumbnail);
> > -    return E_NOTIMPL;
> > +    TRACE("(%p,%p)\n", iface, ppIThumbnail);
> > +
> > +    if (!ppIThumbnail) return E_INVALIDARG;
> > +
> > +    *ppIThumbnail = NULL;
> > +    return WINCODEC_ERR_CODECNOTHUMBNAIL;
> >  }
> 
> The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise, GetThumbnail
> is supported for ICO frames.

It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of
E_INVALIDARG. Real implementation depends on the codec set, and although
obviously MS implementation returns a real interface, that doesn't mean
that an implementation that returns WINCODEC_ERR_CODECNOTHUMBNAIL is wrong.

-- 
Dmitry.



More information about the wine-devel mailing list